Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: look for slug instead of id #736

Closed
wants to merge 3 commits into from

Conversation

otbe
Copy link
Contributor

@otbe otbe commented Aug 26, 2024

Motivation

closes #668

I tested it for "inventoryadjusted" (thats why I changed the ID there) however versioning in general seems to be a bit broken.
It works for domains but changelog page is empt and it does not work at all for services (also no changelogs). Not quite sure since when and at least this is what happens with the default example. Can you verify? (I always have issues running this)

Have you read the Contributing Guidelines on pull requests?

Yes

@otbe otbe requested a review from boyney123 as a code owner August 26, 2024 12:20
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 9d14db7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boyney123
Copy link
Collaborator

Thank you @otbe , not ignoring this! Will take a look later half of this week, thanks mate!

@otbe otbe changed the title look for slug instead of id fix: look for slug instead of id Aug 29, 2024
@otbe
Copy link
Contributor Author

otbe commented Sep 6, 2024

Anything I can do here? :D @boyney123
Last missing bit to finally switch to ECv2 for us 🥳

@boyney123
Copy link
Collaborator

Thanks @otbe sorry for the turn around. I fixed in #772, same fix as yours without the id changes.

Not ideal long term, need a better solution, but happy to merge this to get you unblocked!

@boyney123 boyney123 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelogs are not detected if id of message is not identical to folder name
2 participants